Adds From<iXXX> implementations to fields
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
changed the title
From<iXXX> implementations to quadratic / field extensionsFrom<iXXX> implementations to quadratic / cubic field extensions
huitseeker
force-pushed
the
from_extensions
branch
from
f71d213
to
fc60ad5
Compare
|
Should we add these |
huitseeker
changed the title
From<iXXX> implementations to quadratic / cubic field extensionsFrom<iXXX> implementations to prime / quadratic / cubic field extensions
|
@ValarDragon Good question. It breaks compatibility of the libraries out there which may implement an |
huitseeker
force-pushed
the
from_extensions
branch
from
0845db3
to
133b54a
Compare
ValarDragon
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
This looks good to me! Thanks for adding it to fields.
I've never seen / used paste before, but from looking at the docs this seems right to me.
cref #226, but I think its fine to assume that the ordering -(p-1)/2..0..(p-1)/2 would be implied for signed ints here
|
@ValarDragon FYI, you can inspect the output with cargo expand |
huitseeker
changed the title
From<iXXX> implementations to prime / quadratic / cubic field extensionsFrom<iXXX> implementations to prime / quadratic / cubic field (extensions)
Those delegate to the respective, existing `From<uXXX>` implementations for `XXX` in `[8, 16, 32, 64, 128]`
huitseeker
force-pushed
the
from_extensions
branch
from
133b54a
to
433ce13
Compare
Pratyush
requested changes
Apr 22, 2021
Pratyush
approved these changes
Apr 22, 2021
Pratyush
changed the title
From<iXXX> implementations to prime / quadratic / cubic field (extensions)From<iXXX> implementations to fields
6 tasks
huitseeker
added a commit
to huitseeker/algebra
that referenced
this pull request
Apr 23, 2021
weikengchen
added a commit
that referenced
this pull request
Apr 23, 2021
…lize` (#265) * Implements hashing as a blanket trait for instances of `CanonicalSerialize` - this saves an alllocation w.r.t the suggested approach by implementing `io::Write` on the input instance of `digest::Digest`, - note that most instances of `digest::Digest` [already](https://gist.github.com/huitseeker/e827161413063e347ce5a496b66ff287) have an [`io::Write` instance](https://github.com/rustcrypto/hashes#hashing-readable-objects), but `CanonicalSerialize` consuming its `io::Write` argument prevents its usage, - this hence implements `io::Write` on a [cheap newtype wrapper](https://rust-unofficial.github.io/patterns/patterns/behavioural/newtype.html) Fixes #86 * Adjust post review - rename Hash -> CanonicalSerialize Ext according to [extension trait best practices](https://rust-lang.github.io/rfcs/0445-extension-trait-conventions.html#the-convention) - add the same structure for hashing uncompressed bytes * Changelog entries for #263, #265 * Update CHANGELOG.md Co-authored-by: Weikeng Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those delegate to the respective, existing
From<uXXX>implementations forXXXin[8, 16, 32, 64, 128]